Fix memory grow on SGX platform #4651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikehara
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
yamt
reviewed
Oct 1, 2025
| } | ||
|
|
||
| void * | ||
| os_mremap(void *old_addr, size_t old_size, size_t new_size) |
There was a problem hiding this comment.
don't you want to drop core/shared/platform/common/memory from core/shared/platform/linux-sgx/shared_platform.cmake ?
There was a problem hiding this comment.
Thanks! I dropped it from shared_platform.cmake.
…clude platform_api_memory.cmake
yamt
reviewed
Oct 2, 2025
| endif() | ||
|
|
||
| include (${CMAKE_CURRENT_LIST_DIR}/../common/memory/platform_api_memory.cmake) | ||
| set (source_all ${source_all} ${PLATFORM_COMMON_MEMORY_SOURCE}) |
There was a problem hiding this comment.
Thank you for pointing that out. I overlooked it.
… unnecessary PLATFORM_COMMON_MEMORY_SOURCE
yamt
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4648.