Skip to content

image::copy take no rect param (never implemented) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

image::copy take no rect param (never implemented) #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cpp/image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ PYBIND11_MODULE(image, m)
.def(py::init<int, int, image::format_enum>(), py::arg("iwidth"), py::arg("iheight"), py::arg("iformat"))
.def("bytes_per_row", &image::bytes_per_row)
// .def("const_data", &image::const_data)
#if POPPLER_VERSION_MAJOR >= 25
.def("copy", &image::copy)
#else
.def("copy", &image::copy, py::arg("rect") = rect())
#endif
.def("data", &data)
.def("set_data", &set_data)
.def("format", &image::format)
Expand All @@ -114,4 +118,4 @@ PYBIND11_MODULE(image, m)
m.def("supported_image_formats", &image::image::supported_image_formats);
}

} // namespace poppler
} // namespace poppler
2 changes: 1 addition & 1 deletion src/poppler/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def const_data(self):
return self._image.data()

def copy(self, rect=None):
image = self._image.copy(rect or Rectangle()._rect)
image = self._image.copy()
return Image.from_object(image)

@property
Expand Down