This repository was archived by the owner on Sep 8, 2025. It is now read-only.
no idea how but it worked added event on_livestream_end #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibere
suggested changes
Jan 23, 2024
kick/client.py
Outdated
| livestream: `PartialLivestream` | ||
| The livestream | ||
| """ | ||
| async def on_livestream_end(self, StreamEnd: Endstream) -> None: |
There was a problem hiding this comment.
Parameters/variables should be in snake_case
kick/client.py
Outdated
| """ | ||
| |coro| | ||
| on_livestream_start is an event that can be overriden with the `Client.event` decorator or with a subclass. |
There was a problem hiding this comment.
you forgot to change the description when copy pasting the docstring
kick/client.py
Outdated
| Parameters | ||
| ----------- | ||
| livestream: `PartialLivestream` |
There was a problem hiding this comment.
These are the wrong parameters, appears you forgot to change those too when copy pasting the docstring
kick/livestream.py
Outdated
| self._data = data | ||
| self.http = http | ||
|
|
||
| self.id: int = data["id"] |
kick/livestream.py
Outdated
| self.http = http | ||
|
|
||
| self.id: int = data["id"] | ||
| self.channel_id: int = data["channel"]["id"] |
kick/livestream.py
Outdated
| def __repr__(self) -> str: | ||
| return f"<Livestream id={self.id} title={self.title} streamer={self.slug}>" | ||
|
|
||
| class Endstream: |
There was a problem hiding this comment.
- This should be in PastalCase
- Throughout the rest of the library, a livestream is referred to as a "livestream" and not a "stream", this class should conform to the same standard. Ex: "LivestreamEnd"
kick/types/ws.py
Outdated
|
|
||
| class StreamEndPayload(TypedDict): | ||
| id: int | ||
| channel_id: int |
There was a problem hiding this comment.
This is different from how your "Endstream" class uses it
kick/ws.py
Outdated
| self.http.client.dispatch(event, user) | ||
|
|
||
| case "App\\Events\\StopStreamBroadcast": | ||
| Endstreams = Endstream(data=data["livestream"], http=self.http) |
There was a problem hiding this comment.
variables should be in camel_case
| match raw_data["event"]: | ||
| case "App\\Events\\ChatMessageEvent": | ||
| msg = Message(data=data["livestream"], http=self.http) | ||
| msg = Message(data=data, http=self.http) |
There was a problem hiding this comment.
This reverts changes from your lasts PR
There was a problem hiding this comment.
that chatmsg not livestream hmm
|
Also, please run black on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lmao