Skip to content

Conversation

pluckySquid
Copy link

Created a c# builder. The csharp.xsl builder generates a C# source file (*.cs) containing entity frameworks. The defined C# classes can be utilized in C# applications for persisting profiles to a database.

@tviegut tviegut self-requested a review April 3, 2025 16:58
@tviegut tviegut assigned tviegut and unassigned tviegut Apr 3, 2025
Copy link
Contributor

@tviegut tviegut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yunshu,

Hopefully the recommended changes are not much effort. Thanks!

Todd

Copy link
Contributor

@tviegut tviegut Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yunshu,

Thanks for your pull request!! :) Again, great job and thank you for contributing to the community.

Todd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to relocate this back within the /shipped-builders and name the subfolder csharp-entity-framework instead of csharp

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I will do it right now and send you the new PR! I really appreciate all the help!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments for folder structure/location as on my prior comments...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename csharp.xsl to csharp-entity-framework.xsl

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Todd,

Thank you for the commends! Should I put the update of the README.md under "Builders Shipped with CIMTool" or keep it under "Community Developed Builders"?

Thanks!

best,
Yunshu Wang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import-builder.png would need to be refreshed to reflect the renaming (sorry for the double work Yunshu!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants