Skip to content

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Oct 30, 2025

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web

Introduces a factory function for creating resource signals and refactors the state proxy to use this factory. This reduces code duplication and improves maintainability.

Co-authored-by: bryce <[email protected]>
@cursor
Copy link

cursor bot commented Oct 30, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: 9e94807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Error Error Oct 30, 2025 4:25am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/refactor-signal-architecture-for-scalability-9642

Comment @coderabbitai help to get the list of available commands and usage tips.

Introduce a registry for resource signals and a helper function to retrieve them. This simplifies signal management and makes it easier to add new resources.

Co-authored-by: bryce <[email protected]>
This change introduces a map to store and retrieve signal sets by resource name, simplifying signal access and removing redundant signal getters from the State class.

Co-authored-by: bryce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants