fix(clerk-js): Navigate to /sign-up/continue with ticket strategy
#7101
Conversation
🦋 Changeset detectedLatest commit: f3516ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (10)packages/clerk-js/src/ui/**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/clerk-js-ui.mdc)
Files:
**/*.{js,jsx,ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
packages/**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
packages/**/*.{ts,tsx,d.ts}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{jsx,tsx}📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Files:
**/*.{js,ts,tsx,jsx}📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
**/*.tsx📄 CodeRabbit inference engine (.cursor/rules/react.mdc)
Files:
.changeset/**📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)
🔇 Additional comments (2)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
|
We've done some testing and the password field is being sent as empty even tho is not being displayed on the sign-up form. I'll update the changes here soon to address that. |
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
2d695f9 to
e42d5f6
Compare
This comment has been minimized.
This comment has been minimized.
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
e42d5f6 to
21e0d93
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx(4 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
packages/clerk-js/src/ui/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/clerk-js-ui.mdc)
packages/clerk-js/src/ui/**/*.{ts,tsx}: Element descriptors should always be camelCase
Use element descriptors in UI components to enable consistent theming and styling via appearance.elements
Element descriptors should generate unique, stable CSS classes for theming
Element descriptors should handle state classes (e.g., cl-loading, cl-active, cl-error, cl-open) automatically based on component state
Do not render hard-coded values; all user-facing strings must be localized using provided localization methods
Use the useLocalizations hook and localizationKeys utility for all text and error messages
Use the styled system (sx prop, theme tokens, responsive values) for custom component styling
Use useCardState for card-level state, useFormState for form-level state, and useLoadingStatus for loading states
Always use handleError utility for API errors and use translateError for localized error messages
Use useFormControl for form field state, implement proper validation, and handle loading and error states in forms
Use localization keys for all form labels and placeholders
Use element descriptors for consistent styling and follow the theme token system
Use the Card and FormContainer patterns for consistent UI structure
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{jsx,tsx}: Use error boundaries in React components
Minimize re-renders in React components
**/*.{jsx,tsx}: Always use functional components with hooks instead of class components
Follow PascalCase naming for components:UserProfile,NavigationMenu
Keep components focused on a single responsibility - split large components
Limit component size to 150-200 lines; extract logic into custom hooks
Use composition over inheritance - prefer smaller, composable components
Export components as named exports for better tree-shaking
One component per file with matching filename and component name
Use useState for simple state management
Use useReducer for complex state logic
Implement proper state initialization
Use proper state updates with callbacks
Implement proper state cleanup
Use Context API for theme/authentication
Implement proper state selectors
Use proper state normalization
Implement proper state persistence
Use React.memo for expensive components
Implement proper useCallback for handlers
Use proper useMemo for expensive computations
Implement proper virtualization for lists
Use proper code splitting with React.lazy
Implement proper cleanup in useEffect
Use proper refs for DOM access
Implement proper event listener cleanup
Use proper abort controllers for fetch
Implement proper subscription cleanup
Use proper HTML elements
Implement proper ARIA attributes
Use proper heading hierarchy
Implement proper form labels
Use proper button types
Implement proper focus management
Use proper keyboard shortcuts
Implement proper tab order
Use proper skip links
Implement proper focus traps
Implement proper error boundaries
Use proper error logging
Implement proper error recovery
Use proper error messages
Implement proper error fallbacks
Use proper form validation
Implement proper error states
Use proper error messages
Implement proper form submission
Use proper form reset
Use proper component naming
Implement proper file naming
Use proper prop naming
Implement proper...
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/react.mdc)
**/*.tsx: Use proper type definitions for props and state
Leverage TypeScript's type inference where possible
Use proper event types for handlers
Implement proper generic types for reusable components
Use proper type guards for conditional rendering
Files:
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
🧬 Code graph analysis (1)
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx (3)
packages/clerk-js/src/ui/components/SignUp/signUpFormHelpers.ts (1)
determineActiveFields(49-57)packages/clerk-js/src/ui/components/SignUp/SignUpSocialButtons.tsx (1)
SignUpSocialButtons(21-93)packages/clerk-js/src/ui/components/SignUp/SignUpForm.tsx (1)
SignUpForm(21-141)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (5)
packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx (5)
4-4: LGTM!The
useMemoimport is correctly added to support the memoization logic introduced later in the component.
133-141: Correctly identifies legal-consent-only state.The memoization logic properly detects when only the
legal_acceptedfield is missing with no unverified fields, which aligns with the PR objective to fix the IdP-initiated flow bug. The dependencies and null-safety checks are appropriate.
142-150: LGTM!Passing
signUptodetermineActiveFieldsenables more precise field determination based on the sign-up state, which is necessary for the legal-consent-only flow.
446-456: LGTM!Correctly hides social authentication buttons when only legal consent is required. This prevents showing unnecessary authentication options after the user has already authenticated via enterprise SSO.
462-462: LGTM!Passing
onlyLegalAcceptedMissingtoSignUpFormenables the form to conditionally render only the legal consent field and submit button, which aligns with the PR objective.
| // Do not submit password field when patching sign up with legal missing only | ||
| if (onlyLegalAcceptedMissing) { | ||
| delete fields.password; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Avoid direct mutation of the fields object.
While this achieves the goal of excluding the password field, directly mutating fields with delete violates immutability principles and could cause confusion or subtle bugs if fields is referenced elsewhere.
Apply this diff to filter password during submission instead of mutating:
- // Do not submit password field when patching sign up with legal missing only
- if (onlyLegalAcceptedMissing) {
- delete fields.password;
- }
-
type FormStateKey = keyof typeof formState;
const fieldsToSubmit = Object.entries(fields).reduce((acc, [k, v]) => {
+ // Do not submit password field when patching sign up with legal missing only
+ if (onlyLegalAcceptedMissing && k === 'password') {
+ return acc;
+ }
acc.push(...(v && formState[k as FormStateKey] ? [formState[k as FormStateKey]] : []));
return acc;
}, [] as Array<FormControlState>);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Do not submit password field when patching sign up with legal missing only | |
| if (onlyLegalAcceptedMissing) { | |
| delete fields.password; | |
| } | |
| type FormStateKey = keyof typeof formState; | |
| const fieldsToSubmit = Object.entries(fields).reduce((acc, [k, v]) => { | |
| // Do not submit password field when patching sign up with legal missing only | |
| if (onlyLegalAcceptedMissing && k === 'password') { | |
| return acc; | |
| } | |
| acc.push(...(v && formState[k as FormStateKey] ? [formState[k as FormStateKey]] : [])); | |
| return acc; | |
| }, [] as Array<FormControlState>); |
🤖 Prompt for AI Agents
In packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx around lines 263
to 266, the code currently deletes fields.password directly which mutates the
incoming fields object; instead create a new object for submission that omits
the password when onlyLegalAcceptedMissing is true (e.g., use object spread and
conditional property omission or a shallow copy filtered to exclude the password
key) so the original fields remains immutable and types are preserved; replace
the delete with constructing a newSubmissionFields variable and use that for the
patch/submit call.
21e0d93 to
cbeeba6
Compare
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
cbeeba6 to
f48255c
Compare
|
Found 75 test failures on Blacksmith runners:
|
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
f48255c to
9140af7
Compare
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
9140af7 to
41d8c89
Compare
LauraBeatris
changed the title
/sign-up/continue with ticket strategy
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
41d8c89 to
ff00f17
Compare
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
2 times, most recently
from
24d2f43 to
406a7e8
Compare
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
2 times, most recently
from
8ce6d05 to
61d97b1
Compare
LauraBeatris
force-pushed
the
laura/fix-sign-up-with-legal-missing-only
branch
from
61d97b1 to
f3516ce
Compare
Description
We caught a bug on IdP-Initiated flows, with legal consent enabled, where FAPI would redirect to
/sign-upbut the form still gets shown with password even tho it's not required for enterprise SSO.For those cases, where sign-up with ticket has
missing_requirementsstatus, then it should navigate to/sign-up/continueroute to show the missing fields.CleanShot.2025-11-03.at.20.14.12.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit