- 
                Notifications
    
You must be signed in to change notification settings  - Fork 402
 
fix(clerk-js): Ensure errors are being read to screen readers #7111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(clerk-js): Ensure errors are being read to screen readers #7111
Conversation
          🦋 Changeset detectedLatest commit: ab795fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
| 
           The latest updates on your projects. Learn more about Vercel for GitHub. 
  | 
    
          
WalkthroughThe change introduces a dedicated ARIA live region to the FormControl component for announcing feedback messages to screen readers. The visually hidden live region replaces aria-live semantics previously applied to individual feedback components. Tests are updated to verify the live region's content rather than element attributes. Changes
 Sequence DiagramsequenceDiagram
    participant User
    participant FormControl
    participant LiveRegion as Live Region<br/>(aria-live)
    participant ScreenReader as Screen Reader
    User->>FormControl: Submit form / trigger validation
    FormControl->>FormControl: Feedback state changes
    FormControl->>LiveRegion: Update content with new feedback
    LiveRegion->>ScreenReader: Content changed (polite)
    ScreenReader->>User: Announces feedback message
    Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 
 Poem
 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
 ✅ Passed checks (4 passed)
 ✨ Finishing touches
 🧪 Generate unit tests (beta)
 Comment   | 
    
| 
           !snapshot  | 
    
| 
           Hey @alexcarpenter - the snapshot version command generated the following package versions: 
 Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact
 npm i @clerk/[email protected] --save-exact | 
    
Description
Why Both Are Needed
So you get:
fixes USER-3837
Testing
Screen.Recording.2025-10-31.at.1.45.07.PM.mov
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change