-
Notifications
You must be signed in to change notification settings - Fork 402
fix(clerk-js,types): Add hasBeenFinalized to prevent null updates #7118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vincent-and-the-doctor
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a58434a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Found 19 test failures on Blacksmith runners:
|
Description
This PR fixes an issue where
SignIn(null)was propagated to our signals when thesignInwas completed. This is due to client piggybacking. Now, theSignIn(null)will only be propagated ifhasBeenFinalizedis true, which indicates thatsignIn.finalizewas called on the instance (and that it can be safely overwritten since there's nothing left to do to it).Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change