Skip to content

Fix missing/broken query filters for name and content in DNS Record List #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing/broken query filters for name and content in DNS Record List #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/Endpoints/DNS.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,33 @@ public function addRecord(
return false;
}

/**
* Get a List of Records that matches the specified filters
* @param string $zoneID
* @param string $type
* @param string $name Only one name is allowed as of 2025-02-21 | For filtering, use parameter $nameFilterMode
* @param string $content Only one content value is allowed as of 2025-02-21 | For filtering, use parameter $contentFilterMode
* @param int $page
* @param int $perPage
* @param string $order
* @param string $direction
* @param string $match
* @param string $nameFilterMode Can be either of: contains | starts_with | ends_with
* @param string $contentFilterMode Can be either of: contains | starts_with | ends_with
* @return \stdClass
*/
public function listRecords(
string $zoneID,
string $type = '',
string $name = '',
string $content = '',
int $page = 1,
int $perPage = 20,
int $page = 1,
int $perPage = 20,
string $order = '',
string $direction = '',
string $match = 'all'
string $match = 'all',
string $nameFilterMode = '',
string $contentFilterMode = ''
): \stdClass {
$query = [
'page' => $page,
Expand All @@ -96,11 +113,15 @@ public function listRecords(
$query['type'] = $type;
}

if (!empty($name)) {
if (!empty($name) && !empty($nameFilterMode)) {
$query["name.$nameFilterMode"] = $name;
} elseif (!empty($name)) {
$query['name'] = $name;
}

if (!empty($content)) {
if (!empty($content) && !empty($contentFilterMode)) {
$query["content.$contentFilterMode"] = $content;
} elseif (!empty($content)) {
$query['content'] = $content;
}

Expand Down