Skip to content

provide password via environment instead of command line #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

provide password via environment instead of command line #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bufio"
"bytes"
"math"
"os"
"os/exec"
"regexp"
"strconv"
Expand Down Expand Up @@ -261,8 +262,11 @@ func ipmitoolConfig(config IPMIConfig) []string {
if config.User != "" {
args = append(args, "-U", config.User)
}
// Using -P for the password is bad, since it would show up in the
// process info (ps). Instead use -E and provide the password via
// environment variable IPMITOOL_PASSWORD
if config.Password != "" {
args = append(args, "-P", config.Password)
args = append(args, "-E")
}
if config.Timeout != 0 {
args = append(args, "-N", strconv.FormatInt(config.Timeout, 36))
Expand Down Expand Up @@ -299,6 +303,16 @@ func ipmitoolOutput(target ipmiTarget, command string) (string, error) {
cmdConfig = append(cmdConfig, cmdCommand...)

cmd := exec.Command("ipmitool", cmdConfig...)

// Using -P for the password is bad, since it would show up in the
// process info (ps). Instead use -E and provide the password via
// environment variable IPMITOOL_PASSWORD
if target.config.Password != "" {
passwordEnv := "IPMITOOL_PASSWORD=" + target.config.Password
newEnv := append(os.Environ(), passwordEnv)
cmd.Env = newEnv
}

var outBuf bytes.Buffer
cmd.Stdout = &outBuf
cmd.Stderr = &outBuf
Expand Down