-
Notifications
You must be signed in to change notification settings - Fork 36
[wip] Update wasm exception handling model #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 21 21
Lines 853 853
Branches 87 87
=======================================
Hits 699 699
Misses 154 154 🚀 New features to boost your workflow:
|
|
Once ready, add test We were somewhat checking the older emscripten EH model here |
|
Once its ready will this PR fix this issue #412 given it involves mentions of |
Well the changes above technically come in at runtime to generate correct wasm from the LLVM module. Feel free to compare the 2 wasms actually
Compare something like to see the difference in symbols. What you are talking about is build time stuff. So although relevant, not addressed through the above changes just yet. Let me address them though ! |
Description
Hi,
Today while building xeus-cpp on emscripten-forge's emscripten-4x branch, I saw this
This was expected because
-fwasm-exceptionsand-sSUPPORT_LONGJMP=wasm)-fwasm-exceptionspulls in the following-sSUPPORT_LONGJMP=wasmwhich is an emcc specific flag boils down to-mllvm -wasm-enable-sjljwhich can be used through clang.So basically we end up replicating the same result but with a different exception handling model.

Type of change
Please tick all options which are relevant.