Skip to content

RSec Admin Nomination Page - "New Officer" blank error check + Return properly after redirect #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RSec Admin Nomination Page - "New Officer" blank error check + Return properly after redirect #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce2a98
Add error check for blank user when electing a new officer
ochan1 Jan 26, 2025
ab56c1d
Update add_elected to return properly after redirect and error
ochan1 Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/controllers/admin/rsec_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,18 @@ def find_members
# for the POSITION.
#
def add_elected
if params[:position] == ""
redirect_to admin_rsec_elections_path, notice: "Failed to elect for selected position, since no position was selected"
return
end
if params[:person_id] == ""
redirect_to admin_rsec_elections_path, notice: "Failed to elect for \"#{params[:position]}\" because no one was selected"
return
end
e = Election.new(person_id: params[:person_id].to_i, position: params[:position])
unless e.valid? && e.save
return redirect_to admin_rsec_elections_path, notice: "Failed to elect: #{e.person} because #{e.errors.inspect}"
redirect_to admin_rsec_elections_path, notice: "Failed to elect: #{e.person} because #{e.errors.inspect}"
return
end
redirect_to with_anchor(admin_rsec_elections_path,e.position), notice: "Nominated #{e.position} officer #{e.person.full_name}"
end # add_elected
Expand Down