Add zstd decompression support for overlaybd-apply #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigVan
requested changes
Aug 11, 2025
adam-rl
commented
Aug 12, 2025
| ${PHOTON_INCLUDE_DIR} | ||
| ) | ||
|
|
||
| target_link_libraries(zstd_lib photon_static ${LIBZSTD}) |
Contributor
Author
There was a problem hiding this comment.
I realized we already link zstd, no need to pull a copy from github.
| } | ||
| src_file = open_gzfile_adaptor(input_path.c_str()); | ||
| } else if (is_zstdfile(tarf)) { | ||
| src_file = open_zstdfile_adaptor(tarf, /*ownership=*/false); |
Contributor
Author
There was a problem hiding this comment.
The control flow here is a bit tricky, as we defer delete tarf. So I just make sure we don't take ownership in the zstd file adapter.
Contributor
Author
|
Ready for another round of review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds support to decompress tar archives originally compressed with ZSTD in overlaybd-apply.
Please check the following list: