Skip to content

fix(pty) : Use more safe package rustix to resize pty #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix(pty) : Use more safe package rustix to resize pty #440

merged 1 commit into from
Oct 17, 2025

Conversation

jokemanfire
Copy link
Contributor

avoid using the nix's unsafe ioctl call

@github-actions github-actions bot added C-runc-shim Runc shim C-shim Containerd shim labels Oct 9, 2025
@jokemanfire
fix(pty) : Use more safe package rustix to resize pty
1b4c083 
avoid using the nix's unsafe ioctl call
Signed-off-by: jokemanfire <[email protected]>
@mxpv mxpv added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Oct 16, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@jokemanfire
Copy link
Contributor Author

Hi @mxpv .
I’d love to become a reviewer for this repo. As a regular user of this repo, I deeply understand its value and have the bandwidth to actively contribute and have enough time to do it. My firsthand experience will help me provide practical feedback and improvements.
Best Regards.

@mxpv mxpv added this pull request to the merge queue Oct 17, 2025
Merged via the queue into containerd:main with commit 41d7e2f Oct 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

C-runc-shim Runc shim C-shim Containerd shim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jokemanfire @mxpv