Add unit tests for erofs reading+write cycles #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use this to add lots of unit tests. Assisted-by: Claude Code Signed-off-by: Colin Walters <[email protected]>
…ry bug Add a comprehensive regression test that reproduces the bug fixed in PR inline directory sections as DirectoryBlock, causing a panic. The test generates an erofs image on-the-fly using C mkcomposefs, which (unlike the Rust implementation) creates directories with empty inline sections. This reveals a key difference: the C implementation stores only the parent reference without . and .. entries when a directory is empty, while the Rust implementation always includes those entries. The test demonstrates both: 1. A synthetic case showing DirectoryBlock::n_entries() panics on empty inline data 2. The actual bug triggered by collect_objects() on the C-generated image The test is marked #[ignore] so it doesn't break CI until PR containers#188's fix is applied. When run with --ignored, it passes by catching the expected panics. Asissted-by: Claude Code Signed-off-by: Colin Walters <[email protected]>
|
Hmm looks like there's CI gardening to do here unrelated to extant PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of
Assisted-by: Claude Codehere, but the goal is to add a test case for #188 that can just have its[ignore]removed.