feat: add JCEF reload action #8711
Open
+93
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QianKuang8
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:M
4 tasks
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
dosubot
bot
added
size:L
…r the browser has been created
QianKuang8
force-pushed
the
qian/jcef-reload
branch
from
3fa9081 to
f677852
Compare
…ianKuang8/qian/jcef-reload
Comment on lines
+24
to
+27
| private val myJBCefClient: JBCefClient = JBCefApp.getInstance().createClient().apply { | ||
| setProperty(JBCefClient.Properties.JS_QUERY_POOL_SIZE, 200) | ||
| } | ||
| private val browser: JBCefBrowser = JBCefBrowser.createBuilder().setOffScreenRendering(true).setClient(myJBCefClient).build() |
Collaborator
There was a problem hiding this comment.
how come were changing this logic?
Contributor
Author
There was a problem hiding this comment.
Commit e998ae8 was added to address the issue mentioned in #8085 (comment)
[5473397] WARN - #c.i.u.j.JBCefJSQuery - Set the property JBCefClient.Properties.JS_QUERY_POOL_SIZE to use JBCefJSQuery after the browser has been created
If you have concerns about the fix, I can revert that commit so we can focus on the reload action in this PR.
Patrick-Erichsen
requested changes
Nov 19, 2025
Collaborator
Patrick-Erichsen
left a comment
Patrick-Erichsen
left a comment
There was a problem hiding this comment.
Can you explain the changes here? I'm weary to modify the core browser logic and potentially making things worse than they already are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion in #8085
Add a reload button and an action
With manual test, it works well in normal case. Not 100% sure whether it would work when UI freezes.
video.mp4
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Adds a Reload button for the Continue tool window that rebuilds the JCEF browser and client to recover from freezes or crashes.
New Features
Bug Fixes
Written for commit a097b35. Summary will update automatically on new commits.