Skip to content

Refactoring to Hash Stored User Emails #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactoring to Hash Stored User Emails #64

wants to merge 4 commits into from

Conversation

@JustinNgxyen
Copy link
Contributor

We will hash the email first with sha-256 before we store them in the database for security reasons.

@JustinNgxyen JustinNgxyen requested a review from lxkedinh as a code owner May 1, 2024 04:34
lxkedinh
lxkedinh requested changes May 4, 2024
View reviewed changes
lxkedinh
lxkedinh requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@lxkedinh lxkedinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks to query whether a user has the input email for the login and registration routes fail. You have to refactor to check against the email hash, not the email itself.

@JustinNgxyen JustinNgxyen requested a review from lxkedinh May 16, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lxkedinh lxkedinh Awaiting requested review from lxkedinh lxkedinh is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JustinNgxyen @lxkedinh