Remove the Vector module and replace it by Dynarray #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le (since OCaml 5.2.0). This patch provides a new progress.vector sub-library and allow users to link progress with projects which define their own Vector module. Signed-off-by: Sacha Ayoun <[email protected]> Co-authored-by: Sacha Ayoun <[email protected]> Co-authored-by: Kate <[email protected]>
kit-ty-kate
approved these changes
Sep 19, 2025
|
I'm on holiday but I'll try to give it a sanity test check tonight with our project before you merge if that's ok |
|
That seems to work :) |
|
Thanks both, I will cut a release. |
|
Thank you very much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @giltho and @kit-ty-kate, if you are happy this patch (which compiles #50 into one commit), I'm ready to cut a release.