SCP/SFTP-ing a file into a container over SSH is now possible #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just to be clear, my referenced issue is calling my application's support of SCP "crappy". I think dockerpty is great, and am super happy it exist! Thanks again for making this great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the Apache2 license on the code, so here are the changes I'm making for my needs.
With these changes, it's possible for someone to leverage
dockerptyover an SSH connection and have SCP/SFTP work as expected. It would be up to the calling application to manage cleaning up and teardown of the container, but at leastdockerptywont spin indefinitely when SCP/SFTP triggers an EOF on stdin.I tested this functionality when using the dockerpty.start functionality.
Feel free to take this update, or just close the PR. Thanks for doing 99% of the work and making this awesome library! 😄