Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/http-cache/storage.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,14 @@ Storage.prototype.handleRequest = function(req, res) {
var evaluator = new context.RequestEvaluationContext(req);

this.emit('request', req, res, evaluator);
if (!!evaluator.cacheable) {
if (!!evaluator.retrievable) {
if (this.serveCached(req, res)) {
return true;
} else {
this.prepareWrappers(req, res);
}
}
if (!!evaluator.storable) {
this.prepareWrappers(req, res);
}

return false;
};
Expand Down
21 changes: 21 additions & 0 deletions test/http-cache/storage/memory-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
var helper = require('../../test-helper')
, shared = require('../../support/shared-examples')
, httpCache = helper.httpCache
, assert = require('assert')
, memo = helper.memo
;

Expand All @@ -17,4 +18,24 @@ describe('httpCache.storage.MemoryStorage', function(){
});

shared.behavesLikeACacheStorage(storage);

var method = memo().is(function(){ return 'GET' });
var headers = memo().is(function(){ return {} });

var req = memo().is(function(){
return helper.createRequest({
method: method(),
headers: headers()
});
});

var res = memo().is(function(){
return helper.createResponse(req());
});

it('tries to serve cache if cacheable', function(){
var serveCachedSpy = helper.sinon.spy(storage(), 'serveCached');
storage().handleRequest(req(), res());
assert(serveCachedSpy.called);
});
});