pass a char buffer to simplecpp instead of a stream #6379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
charbuf
branch
8 times, most recently
from
7b20b6d to
a67a83d
Compare
|
The callgrind CI job shows a small reduction in Ir: |
firewave
force-pushed
the
charbuf
branch
3 times, most recently
from
0085e46 to
cb2981d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
charbuf
branch
2 times, most recently
from
10eaa80 to
0b40ad2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
charbuf
branch
2 times, most recently
from
2e85422 to
df92530
Compare
firewave
force-pushed
the
charbuf
branch
2 times, most recently
from
0b25bb8 to
d3e381e
Compare
danmar
reviewed
Aug 28, 2025
firewave
force-pushed
the
charbuf
branch
2 times, most recently
from
a6a7929 to
942b7a6
Compare
|
danmar
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.