Skip to content

enabled and fixed modernize-use-equals-delete clang-tidy warnings #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

enabled and fixed modernize-use-equals-delete clang-tidy warnings #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Checks: >
-modernize-pass-by-value,
-modernize-return-braced-init-list,
-modernize-use-auto,
-modernize-use-equals-delete,
-modernize-use-nodiscard,
-modernize-use-trailing-return-type,
-readability-avoid-nested-conditional-operator,
Expand Down
6 changes: 3 additions & 3 deletions simplecpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,9 @@ class FileStream : public simplecpp::TokenList::Stream {
init();
}

FileStream(const FileStream&) = delete;
FileStream &operator=(const FileStream&) = delete;

~FileStream() override {
fclose(file);
file = nullptr;
Expand Down Expand Up @@ -459,9 +462,6 @@ class FileStream : public simplecpp::TokenList::Stream {
ungetc(ch, file);
}

FileStream(const FileStream&);
FileStream &operator=(const FileStream&);

FILE *file;
int lastCh{};
int lastStatus{};
Expand Down
5 changes: 2 additions & 3 deletions simplecpp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ namespace simplecpp {
Token(const Token &tok) :
macro(tok.macro), op(tok.op), comment(tok.comment), name(tok.name), number(tok.number), whitespaceahead(tok.whitespaceahead), location(tok.location), string(tok.string), mExpandedFrom(tok.mExpandedFrom) {}

Token &operator=(const Token &tok) = delete;

const TokenString& str() const {
return string;
}
Expand Down Expand Up @@ -195,9 +197,6 @@ namespace simplecpp {
TokenString string;

std::set<const Macro*> mExpandedFrom;

// Not implemented - prevent assignment
Token &operator=(const Token &tok);
};

/** Output from preprocessor */
Expand Down