Skip to content

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented Nov 3, 2025

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

aradabir007 and others added 8 commits November 5, 2025 09:14
…shpay#527)

* feat: add script to store dash-cli help output for parsing

* feat: include hash of help for quick reference

* feat: include version in filename

* feat: move repeated fields to metadata object and allow cli errors to bubble up

* feat: add rpc change summary script

* script: update to capture all subcommands also, output summary table

* refactor: improve RPC changes report formatting and organization

- Reorganize report to show consolidated table before detailed sections
- Enhance change detail rendering with grouped, nested bullet points
- Add emoji indicators for change types (➕ added, ➖ removed, ⚠️ deprecated, 🔁 replacement)
- Replace verbose "Notes" column with concise "Change Types" in table
- Add anchor links from table to detailed sections for navigation
- Filter out docs-only changes from consolidated table
- Improve spacing and markdown code block formatting

* refactor: move and rename script

* feat: use core version from jsonl

* refactor: move core rpc scripts

* refactor: rename files

* docs: add readme

* docs: add core 22.1.3 rpc help output

* feat: take filenames as input args for script

Update readme with changes

* chore: remove echo
Update all protx RPC commands to reflect renamed parameters in Dash Core 23.0.0:
- ipAndPort → coreP2PAddrs (accepts string or array)
- platformP2PPort → platformP2PAddrs (accepts string/array)
- platformHTTPPort → platformHTTPSAddrs (accepts string/array)

Updated commands include protx register, protx register_evo, protx register_fund,
protx register_fund_evo, protx register_prepare, protx register_prepare_evo,
protx update_service, and protx update_service_evo variants.
@thephez thephez force-pushed the v23.0-mn-reg-updates branch from fc13313 to d3e8746 Compare November 5, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants