-
Notifications
You must be signed in to change notification settings - Fork 21
CNDB-14199: Expose methods containsDateRangeTypeColumn #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Checklist before you submit for review
|
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java
Show resolved
Hide resolved
src/java/org/apache/cassandra/cql3/statements/schema/AlterTableStatement.java
Show resolved
Hide resolved
c043c88
to
43495d1
Compare
@pkolaczk , I just addressed your comment. Also, for completeness, I want to mention that I am intentionally leaving the testing of the new methods to CNDB. |
43495d1
to
0b30217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Exposes containsDateRangeTypeColumn
methods to support CNDB functionality for detecting date range column types. This enhancement provides visibility into schema components that contain DateRangeType columns.
Key changes:
- Added public method to check for date range columns in table creation and alteration statements
- Implemented date range type detection in CQL3Type system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
CreateTableStatement.java | Added public method to detect DateRangeType columns during table creation |
AlterTableStatement.java | Added base method and override in AddColumns inner class for date range detection |
CQL3Type.java | Added isDateRange() method with implementation for custom types and spelling correction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Neither of the two failures flagged as regressions is related to the changes done here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion to avoid the use of hardcoded string name. Looks good otherwise.
Co-authored-by: Massimiliano Tomassi <[email protected]>
916532e
to
96a222a
Compare
Suggestion committed and branch rebased for final CI test, thanks! |
…TypeStatement and AlterTypeStatement
|
❌ Build ds-cassandra-pr-gate/PR-1914 rejected by Butler1 regressions found Found 1 new test failures
Found 2 known test failures |
testSiftSmall does not fail for me locally and it doesn't seem to be touching anything we touch here. |
What is the issue
...
We need that knowledge for CNDB
What does this PR fix and why was it fixed
...
It exposes
containsDateRangeTypeColumn
methods