CNDB-15086: Do not use LimitingRebufferer when limit is actually disabled #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-1940 rejected by Butler1 regressions found Found 1 new test failures
No known test failures found |
jasonstack
approved these changes
Aug 13, 2025
blambov
reviewed
Aug 14, 2025
| : rebuffererFactory.instantiateRebufferer(); | ||
|
|
||
| if (limiter != null) | ||
| if (limiter != null && limiter.getRate() != Double.MAX_VALUE) |
There was a problem hiding this comment.
Make it limiter.getRange() < Double.MAX_VALUE to also skip the limiter for infinity and NaN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
There is no need to create the LimitingRebufferer if rate limiting is actually disabled.
What does this PR fix and why was it fixed
Do not create the LimitingRebufferer when not needed.
Note: the compaction rate is supposed to be modifiable at runtime. This change allows to do so. Because the change applies only to the case we open a Rebufferer, for a FileHandle that is a short lived object.