CNDB-8830: explicitly log received signal #1950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
|
djatnieks
reviewed
Sep 26, 2025
There was a problem hiding this comment.
It looks like we've lost the previous build results - push a commit or manually trigger the build again?
| assert !isShutdown; | ||
| isShutdown = true; | ||
|
|
||
| logger.info("Running data daemon shutdown hook"); |
There was a problem hiding this comment.
Should it be something like "Running StorageService shutdown hook"?
| drain(false); | ||
| } | ||
|
|
||
| protected synchronized void drain(boolean isFinalShutdown) throws IOException, InterruptedException, ExecutionException |
There was a problem hiding this comment.
I noticed that if isFinalShutdown == true some messages are not logged - I wonder if it would be useful to have those logged in the context of CNDB given the ask in the ticket for more logging?
There was a problem hiding this comment.
They are calling setMode though, which happens to optionally log. We could change those to not log and explicitly log instead, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
To ease service shutdown investigations we could log a received signal.
What does this PR fix and why was it fixed
Logs signals received.