CNDB-15362: Replace SASI by a dummy implementation #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
This patch replaces SASI internals by a no-op implementation that ignores writes and rejects reads. SASI has never been supported, so it's mostly dead code. This would allow us to get rid of code that we are still partially maintaining, spending resources on CI, build, etc. It's still allowed to create new SASI indexes so old schemas keeps working, for example when restoring a snapshot with SASI. However, they will be no-op with a clear client warning about SASI not being supported nor functional anymore.
adelapena
force-pushed
the
CNDB-15362-main
branch
from
d2f752f to
d3ede16
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2013 rejected by Butler1 regressions found Found 1 new test failures
No known test failures found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
SASI has never been supported, so it's mostly dead code. This would allow us to get rid of code that we are still partially maintaining, spending resources on CI, build, etc.
This has already be done in DSE 6.9: https://github.com/riptano/bdp/commit/358767f8ae21c91b8241bc26e98cf7f922daff8b
What does this PR fix and why was it fixed
This patch replaces SASI internals by a no-op implementation that ignores writes and rejects reads. It's still allowed to create new SASI indexes so old schemas keeps working, for example when restoring a snapshot with SASI. However, they will be no-op with a clear client warning about SASI not being supported nor functional anymore.