Skip to content

Conversation

k-rus
Copy link

@k-rus k-rus commented Sep 30, 2025

What is the issue

Fixes https://github.com/riptano/cndb/issues/15519
Compaction might write SAI differently than flush, thus it's good to have tests running after compaction.

What does this PR fix and why was it fixed

Changes to use runThenFlushThenCompact instead of beforeAndAfterFlush in BM25 test. Another test already tests after compaction in addition to memtable and after flush.

Changes to use runThenFlushThenCompact instead of beforeAndAfterFlush
in BM25 test. Another test already tests after compaction in addition to
memtable and after flush.
Copy link

github-actions bot commented Sep 30, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-2026 approved by Butler


Approved by Butler
See build details here

@k-rus k-rus requested a review from a team September 30, 2025 13:00
@k-rus k-rus merged commit 243ca72 into main Oct 1, 2025
491 of 495 checks passed
@k-rus k-rus deleted the rf-15519-bm25-test-after-compaction branch October 1, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants