- 
                Notifications
    
You must be signed in to change notification settings  - Fork 21
 
CNDB-15554: Bump jvector version #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a634e2    to
    a15eed3      
    Compare
  
    f785bd6    to
    b5e76e0      
    Compare
  
    | 
           As it relates to test coverage, there are several code paths that are only reachable if you already have a fused adc graph already or already have bq vectors. At the moment, we don't have a way to write either of these objects/formats, so there isn't a way to add test coverage for them. #2042 will add fused adc and therefore add coverage. BQ is on the road map for later this year. As such, I am going to merge even though we have less than the required test coverage. As it relates to the CNDB PR, we already did the release validation testing with this version on the october release, so I am going to merge and then open the CNDB PR to bring in the latest CC.  | 
    
| 
           Just discovered I can't merge with the current code coverage, so I guess I'll have to look to see if there is a way to fix this.  | 
    
This is only to increase code coverage. We should make this change when we make the fused adc code reachable (it isn't at the moment).
          
 | 
    
          
❌ Build ds-cassandra-pr-gate/PR-2033 rejected by Butler2 regressions found Found 2 new test failures
 Found 1 known test failures | 
    
| 
           the failure seems flaky: It passed on my machine.  | 
    
Fixes: riptano/cndb#15554 Bring in the latest jvector changes. Including a bug fix for a regression introduced in `rc.3` Commits: datastax/jvector@4.0.0-rc.3...4.0.0-rc.5
Fixes: riptano/cndb#15554 Bring in the latest jvector changes. Including a bug fix for a regression introduced in `rc.3` Commits: datastax/jvector@4.0.0-rc.3...4.0.0-rc.5



What is the issue
Fixes: https://github.com/riptano/cndb/issues/15554
What does this PR fix and why was it fixed
Bring in the latest jvector changes. Including a bug fix for a regression introduced in
rc.3Commits: datastax/jvector@4.0.0-rc.3...4.0.0-rc.5