Begin work on MPI parallel calculation of pip weights. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainwoodman
reviewed
Nov 11, 2020
| for realization in my_realizations: | ||
| # Set the seed based on the realization, so that the result is reproducible | ||
| # regardless of which process is working on the realization. | ||
| np.random.seed(realization) |
There was a problem hiding this comment.
What about rng = np.random.RandomState(realization) to avoid the global state?
rainwoodman
reviewed
Nov 11, 2020
| tileselect = None | ||
| if args.tiles is not None: | ||
| tileselect = list() | ||
| with open(args.tiles, "r") as f: |
There was a problem hiding this comment.
suggestion: read on root rank and broadcast.
There was a problem hiding this comment.
Probably also apply to line 99 and 111. Not worth it if there is too much work to make the objects "broadcastable"(e.g. pickling) and also we don't intent to run this with many ranks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress- it is not working code.