Skip to content

devpi-ldap fails on Unicode #19 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

devpi-ldap fails on Unicode #19 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions devpi_ldap/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def _search(self, conn, config, **kw):
search_scope = self._search_scope(config)
attribute_name = config['attribute_name']
found = conn.search(
config['base'], search_filter,
config['base'], search_filter.decode("utf8"),
search_scope=search_scope, attributes=[attribute_name])
if found:
if any(attribute_name in x.get('attributes', {}) for x in conn.response):
Expand Down Expand Up @@ -218,7 +218,7 @@ def _userdn(self, username):
if 'user_template' in self:
return self['user_template'].format(username=username)
else:
result = self._search(None, self['user_search'], username=username)
result = self._search(None, self['user_search'], username=username.encode("utf8"))
if len(result) == 1:
return result[0]
elif not result:
Expand Down Expand Up @@ -252,7 +252,7 @@ def validate(self, username, password):
config = self.get('group_search', None)
if not config:
return dict(status="ok")
groups = self._search(conn, config, username=username, userdn=userdn)
groups = self._search(conn, config, username=username, userdn=userdn.encode("utf8"))
return dict(status="ok", groups=groups)


Expand Down