Switch to Terser library for minification. #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanason
force-pushed
the
introduce-terser
branch
from
2ad3838 to
cda819b
Compare
sanason
force-pushed
the
introduce-terser
branch
from
cda819b to
1a677d6
Compare
sanason
commented
Feb 21, 2025
| run: npm ci --timing | ||
| - name: Lint javascript | ||
| run: npm run lint | ||
| - name: Verify minification uses script |
There was a problem hiding this comment.
This is hacky but I'd like to prevent a re-occurrence of the the situation where package.json suggests that we're using minifier A when really we're using minifier B.
The proper thing to do would be to delete the generated files from source control and have deployment be based on a built artifact. However, given that this project is about to lose most of its engineering support, I don't think this is the right time to make such a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to demystify the process by which the DAP code is minified. In the repo's current state, it is not clear which tool is being used for minification or how that tool is configured. This PR adds an npm script that specifies how minification is to be performed - by the Terser library and with options described in minify_options.json. Terser is not what has been used up to now - currently the code is minified with the Google Closure Compiler. But the Closure Compiler is a Java app, which makes it awkward to use in our npm environment, and the minified file generated by Terser is the same size as the one generated by the Closure Compiler (29 KB), so we aren't losing any performance by switching tools.
One change resulting from this switch - the sourcemap file has been renamed from
Federated.js.mapto the more intuitive nameUniversal-Federated-Analytics-Min.js.map. I'll go through the wiki and update any references toFederated.js.map(I know the self-hosting instructions refer to this file, I'll look for any other places).