Fix issue #1475: SVD now tests for NaN values #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo-ant
reviewed
Sep 19, 2025
| eps: T::RealField, | ||
| max_niter: usize, | ||
| ) -> Option<Self> { | ||
| // Ensure that the matrix is not empty before proceeding |
There was a problem hiding this comment.
I noticed a lot of comments for existing code, that seem a bit verbose to me. Would you mind removing them, since the code is pretty self-documenting?
geo-ant
reviewed
Sep 19, 2025
| // **Check for NaN values in the diagonal elements** | ||
| // We check whether any singular value in the diagonal is NaN by comparing each value to itself. | ||
| // This works because NaN is the only value in Rust that is not equal to itself. | ||
| if diagonal.iter().any(|s| s != s) { |
There was a problem hiding this comment.
did you choose to do it like this because the RealField and ComplexField traits don't expose an is_nan?
|
Hi @rbctz thank you for the PR, I realize this has been a while. Are you still interested in getting this merged? If so, would you see if you could resolve the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes the issue where the program would panic when encountering NaN elements. I tweaked the
try_new_ordered()function to address NaN values accordingly.Details
try_new_ordered()function to handle NaN values gracefully, preventing the program from panicking.svd.rsfile for better legibilityTesting
I tested the changes using the tests provided in the
testsdirectory. The changes were validated by running the existing tests to ensure the program behaves as expected and no panics occur.Fixes #1475