Disable default features for glam
#1510
Merged
+38
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
commented
Apr 17, 2025
Comment on lines
26
to
50
| std = [ | ||
| "matrixmultiply", | ||
| "num-traits/std", | ||
| "num-complex/std", | ||
| "num-rational/std", | ||
| "approx/std", | ||
| "simba/std", | ||
| "glam014?/std", | ||
| "glam015?/std", | ||
| "glam016?/std", | ||
| "glam017?/std", | ||
| "glam018?/std", | ||
| "glam019?/std", | ||
| "glam020?/std", | ||
| "glam021?/std", | ||
| "glam022?/std", | ||
| "glam023?/std", | ||
| "glam024?/std", | ||
| "glam025?/std", | ||
| "glam027?/std", | ||
| "glam028?/std", | ||
| "glam029?/std", | ||
| "glam030?/std", | ||
| ] |
There was a problem hiding this comment.
This is a bit nasty :/ not sure if there's a better way?
|
Seems like a good idea to me, but this PR seems to contain unrelated changes, e.g. to the rustc version used for trybuild tests. |
|
Yeah that's to make CI pass. Won't be needed if we first merge #1505 or some other PR that bumps the version |
The intended approach is to use `serde-serialize-no-std` if serde is needed in `no_std` environments.
This reverts commit 98b3422.
sebcrozet
force-pushed
the
glam-no-default-features
branch
from
16f13ff to
409b9a2
Compare
This reverts commit 46012e8.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, the
convert-glamXYZfeatures addglamas a dependency with default features enabled. This unconditionally enables thestdfeature inglam, making it impossible to usenalgebraandglaminteroperatively with the type conversions inno_stdenvironments.Solution
Disable default features from the
glamdependencies. To make CI pass,stdis still used if it's enabled fornalgebra.Note that I also bumped the rustc version to 1.81.0 here since CI was failing because of it (unrelated to this PR).