Fix rustdoc warnings #1511
Open
Fix rustdoc warnings #1511
+550
−547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublished on `docs.rs`.
``` error: rustc 1.79.0 is not supported by the following package: [email protected] requires rustc 1.81 ``` updated snapshot test ci: snapshot test again, by ```shell TRYBUILD=overwrite cargo +1.81 test stack ```
CGMossa
force-pushed
the
fix_rustdoc_warnings
branch
from
c526702 to
8fe72fc
Compare
|
Oh nice! Activity. I forgot about this completely. |
|
The current CI failure is also happening on |
|
@CGMossa I'm happy to approve but can you double-check that I did the merge commit correctly? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
cargo doc --workspace --no-deps --document-private-itemsusingPlus, I applied suggestions from
markdownlint.Additions due to CI
I had to update the rustc version in CI from 1.79 to 1.81 due to a dev-dependency.
Also, now the snapshots must be upgraded using
TRYBUILD=overwrite cargo +1.81 ..., as there are serious differences in how latest stable behaves vs. 1.81.