Fixed an issue with incorrect left alignment of the placeholder text #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue with incorrect left alignment of the placeholder in certain conditions. You can see an example of the issue at: http://codepen.io/anon/pen/xdFib In the example notice that the placeholder text is to the left of the input field. The fix was to add compensation for x difference like you have for the y difference. You can see the result of applying the fix to the example at: http://codepen.io/anon/pen/numxC The placeholder text is now correctly placed in the the input field.
Author
|
@jackaperkins, @thisandagain can you review this fix and merge it? |
|
+1. I also had this issue, and fixed it the same way before I saw the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with incorrect left alignment of the placeholder in certain conditions.
You can see an example of the issue at: http://codepen.io/anon/pen/xdFib
In the example notice that the placeholder text is to the left of the input field overriding other elements.
The fix was to add compensation for x difference like you have for the y difference.
You can see the result of applying the fix to the example at:
http://codepen.io/anon/pen/numxC
The placeholder text is now correctly placed in the the input field.