This repository was archived by the owner on Nov 27, 2023. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 254
 
921 fix public subnet retrieval #1298
          
     Open
      
      
            PacoVK
  wants to merge
  12
  commits into
  docker-archive:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
PacoVK:921-fix-public-subnet-retrieval
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            921 fix public subnet retrieval #1298
                    PacoVK
  wants to merge
  12
  commits into
  docker-archive:main
from
PacoVK:921-fix-public-subnet-retrieval
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
Signed-off-by: Pascal Euhus <[email protected]>
5d5a00f    to
    8f2f730      
    Compare
  
    | 
           hmm this is here from February anyone tested this?  | 
    
| 
           Any progress with that? #921  | 
    
| 
           This in my case is needed to workaround issue where nfs targets are created in all availability zones, instead of only public ones, where duplicate occurs and whole stack is rollbacked. Happens when you have private networks alongside public ones.  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What I did
Classify VPC subnets and allow Loadbalancer creation in Public subnets only fixes #921 and improves #1064
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did