-
Notifications
You must be signed in to change notification settings - Fork 31
[DRAFT] Add Windows client hint brands override to match header we override natively #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
laghee
wants to merge
11
commits into
main
Choose a base branch
from
km/add-ch-brand-shim
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 03 Nov 2025 17:48:13 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1208581002806545?focus=true
Description
Adding an override for our client hints brands in the JS API to match those we send in the Sec-CH-UA header and resolve breakage caused by current inconsistency between the two.
Testing Steps
Privacy test page TODO
Checklist
Please tick all that apply:
Note
Introduce
uaChBrandsto overridenavigator.userAgentData.brands(preserving GREASE) and add Windows integration tests and pages.uaChBrandsinjected/src/features/ua-ch-brands.jsto overridenavigator.userAgentData.brandsand align with configuredsettings.brands.getHighEntropyValues(['brands'])to return overridden values; caches original/mutated brands.injected/src/features.js(otherFeatures,platformSupport.windows).injected/integration-test/ua-ch-brands.spec.js.injected/integration-test/test-pages/ua-ch-brands/for brand override and missing-brands scenarios.injected/playwright.config.jsfor Windows project.Written by Cursor Bugbot for commit 1125d9d. This will update automatically on new commits. Configure here.