Skip to content

Conversation

@laghee
Copy link
Contributor

@laghee laghee commented Oct 21, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1208581002806545?focus=true

Description

Adding an override for our client hints brands in the JS API to match those we send in the Sec-CH-UA header and resolve breakage caused by current inconsistency between the two.

Testing Steps

Privacy test page TODO

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Introduce uaChBrands to override navigator.userAgentData.brands (preserving GREASE) and add Windows integration tests and pages.

  • Feature: uaChBrands
    • Implement injected/src/features/ua-ch-brands.js to override navigator.userAgentData.brands and align with configured settings.brands.
    • Preserves GREASE brand and position; updates getHighEntropyValues(['brands']) to return overridden values; caches original/mutated brands.
    • Register in injected/src/features.js (otherFeatures, platformSupport.windows).
  • Tests
    • Add Playwright spec injected/integration-test/ua-ch-brands.spec.js.
    • Add test pages/configs under injected/integration-test/test-pages/ua-ch-brands/ for brand override and missing-brands scenarios.
    • Include spec in injected/playwright.config.js for Windows project.

Written by Cursor Bugbot for commit 1125d9d. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 1125d9d
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6908ea8c3b4f230008b2998b
😎 Deploy Preview https://deploy-preview-2028--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

[Beta] Generated file diff

Time updated: Mon, 03 Nov 2025 17:48:13 GMT

Android
    - android/adsjsContentScope.js
  • android/autofillImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant