Skip to content

Fix keyword type for wma #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix keyword type for wma #55

wants to merge 2 commits into from

Conversation

GHTaarn
Copy link
Contributor

@GHTaarn GHTaarn commented Jun 28, 2025

The first of the three tests that I added would fail on the current master branch. This PR allows it to pass which I feel is more correct.

@GHTaarn
Copy link
Contributor Author

GHTaarn commented Jun 28, 2025

The first commit is still an improvement, but after some thought I felt that the second commit is better: The output is always a Vector{Float64}, so there is not much gained by throwing an error if the types of x and wts are different, so this commit allows any combination of Real arrays.

@GHTaarn GHTaarn mentioned this pull request Jun 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GHTaarn