Skip to content

Conversation

@marrbnl
Copy link

@marrbnl marrbnl commented Oct 28, 2025

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?


// recalcuate vertex time using: dt = (SV-PV).Mag()/(pMother/eMother)
// we assume primary vertex is at (0,0,0) with time = 0
// this is done for any secondary vertices 1 um away from primary vertex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to make assumptions about the primary vertex. Simply use the distance to the mother's vertex (and appropriate beta). This way, you correctly capture cascading decays.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with it. The calculation doesn't depend on (0,0,0). It is for any primary vertex.

@marrbnl
Copy link
Author

marrbnl commented Oct 28, 2025

Using the mother particle vertex is easy to implement.

Thinking of cascading decays, we need to add the decay time for the mother to daughters as well, right?

@kkauder
Copy link
Collaborator

kkauder commented Oct 29, 2025

Thinking of cascading decays, we need to add the decay time for the mother to daughters as well, right?

Yes, but that's nothing special, you just need to use t of mother instead of t=0, doesn't matter if you think of the mother as collision vertex or not, it should all recursively work out.

Rongrong Ma and others added 4 commits October 29, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants