Improve documentation around streams, particularly ID generators and adding new streams. #18943
+56
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
approved these changes
Sep 25, 2025
|
|
||
| --- | ||
|
|
||
| ## Cheatsheet for creating a new stream |
There was a problem hiding this comment.
Haven't personally verified this is exhaustive but I do know it was used to create #18968 so should be good ⏩
| @@ -0,0 +1 @@ | |||
| Improve documentation around streams, particularly ID generators and adding new streams. No newline at end of file | |||
There was a problem hiding this comment.
Thanks for updating the docs here instead of letting them die in private 💯
reivilibre
commented
Sep 26, 2025
| _MultiWriterCtxManager(self, self._notifier, n), | ||
| ) | ||
|
|
||
| def get_next_txn(self, txn: LoggingTransaction) -> int: |
There was a problem hiding this comment.
should add to get_next_mult_txn too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arises mostly from my recent experience adding a stream for Thread Subscriptions
and trying to help others add their own streams.
cc @kegsay