Fix exclude option regression (methods normalization + regex support) #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the exclusion of HTTP methods to ensure case-insensitive matching and supports RegExp for excluded paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the OpenAPI refactor, I found two issues related to the
excludeoption:exclude.methodscase sensitivityPreviously, the
excludeMethodsarray elements were provided in uppercase. After the refactor, in the implementation the path method is converted to lowercase before comparison with excluded elements, which broke the functionality.This fix ensures that the provided array is normalized to lowercase as well, so users can supply
exclude.methodsin any case format.exclude.pathsregex supportAccording to the type definitions,
exclude.pathsshould accept both strings and regular expressions. However, the implementation only handled string equality, ignoring regex patterns.This PR adds proper handling for regex values.