Check for empty localarrays when Distributions are made #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that this has to duplicate the check for empty localarrays three times. Two for each Distribution classmethod, and one for Distribution's |
Contributor
|
@cowlicks please rebase against master. |
Contributor
Author
|
It looks like we have some conflicting implementations here. This PR checks that we don't create any empty LocalArrays, but it looks like that is intended behavior in some of the slicing PR's. See this |
Contributor
|
Postponing to 0.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks to all the
Distributioncreation paths to make sure that no empty localarrays are created. This should fail several tests until PR #444 is merged. This closes issue #445.This also adds a
Distribution.localsizesinstance method, which returns the sizes of the localarrays.