[SleepLog] Fix important bugs with HRM being undefined #4023
+24
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyttan
reviewed
Oct 7, 2025
thyttan
reviewed
Oct 7, 2025
Removed unnecessary whitespace and comments in health function.
thyttan
reviewed
Oct 7, 2025
thyttan
reviewed
Oct 7, 2025
| status: data.status, | ||
| consecutive: data.consecutive, | ||
| prevStatus: data.status === this.status ? undefined : this.status, | ||
| prevStatus: this.status, |
There was a problem hiding this comment.
Is this change needed? I wonder if it could have some unintended side effect?
thyttan
reviewed
Oct 7, 2025
ondras12345
reviewed
Oct 7, 2025
|
Not for this PR, but would you find it useful to have typescript check this code, to stop similar errors in future? I wouldn't mind making the change if so |
|
@bobrippling That would be good! Just a question: how does typescript checking differ from the checks that are already done? |
It'd be able to find typos such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bugs relating to HRM data being incorrectly pulled in and comparing with undefined.
This comes from the discussion at #4010, and has been tested by me and @ondras12345
From the looks of it, this also fixes #4012