Skip to content

Conversation

@anuj0456
Copy link

Summary

  • Example file for image augmentation. This ipynb file explains all the functions described in the image functional.py in details. It will help first timer/expret to refer this document while using Augly for image augmentation.
  • Correctd few assertions that I cam across while creating this file.

correct assertion operator and message in blur function
correction in assert statements
check the value of mean in random_noise
@facebook-github-bot
Copy link
Contributor

Hi @anuj0456!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@returns: the augmented PIL Image
"""
assert ratio > 0, "Expected 'ratio' to be a positive number"
assert ratio >= 0, "Ratio should be a positive number greater than 0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is not a positive number so you can just say "XX should be a positive number". Please revise all these accordingly in this file for consistency. Condition is the same for all, so you can use the same message everywhere. Also why did you allow 0 in asserts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants