Skip to content

{Build} C++ Remove useless return const type #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

{Build} C++ Remove useless return const type #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions core/data_provider/SubstreamSelector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,15 @@ SubstreamSelector::SubstreamSelector(const std::set<vrs::StreamId>& allStreamIds
}

/* info about available streams */
const std::set<vrs::StreamId> SubstreamSelector::getStreamIds() const {
std::set<vrs::StreamId> SubstreamSelector::getStreamIds() const {
return allStreamIds_;
}

const std::set<vrs::RecordableTypeId> SubstreamSelector::getTypeIds() const {
std::set<vrs::RecordableTypeId> SubstreamSelector::getTypeIds() const {
return typeIds_;
}

const std::set<vrs::StreamId> SubstreamSelector::getStreamIds(
const vrs::RecordableTypeId& typeId) const {
std::set<vrs::StreamId> SubstreamSelector::getStreamIds(const vrs::RecordableTypeId& typeId) const {
return typeIdToStreamIds_.at(typeId);
}

Expand All @@ -47,7 +46,7 @@ bool SubstreamSelector::isActive(const vrs::StreamId& streamId) const {
return selectedStreamIds_.count(streamId);
}

const std::set<vrs::StreamId> SubstreamSelector::getActiveStreamIds() const {
std::set<vrs::StreamId> SubstreamSelector::getActiveStreamIds() const {
return selectedStreamIds_;
}

Expand Down
8 changes: 4 additions & 4 deletions core/data_provider/SubstreamSelector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@ class SubstreamSelector {
/**
* @brief Returns the list of available stream ids
*/
const std::set<vrs::StreamId> getStreamIds() const;
std::set<vrs::StreamId> getStreamIds() const;
/**
* @brief Returns the list of available type ids
*/

const std::set<vrs::RecordableTypeId> getTypeIds() const;
std::set<vrs::RecordableTypeId> getTypeIds() const;
/**
* @brief Returns the list of stream ids of a specified type
* @param typeId the ID of a VRS recordable type e.g. vrs::RecordableTypeId::SlamCameraData
*/

const std::set<vrs::StreamId> getStreamIds(const vrs::RecordableTypeId& typeId) const;
std::set<vrs::StreamId> getStreamIds(const vrs::RecordableTypeId& typeId) const;

/* info about selected streams */

Expand All @@ -57,7 +57,7 @@ class SubstreamSelector {
* @brief Returns all selected streams
*/

const std::set<vrs::StreamId> getActiveStreamIds() const;
std::set<vrs::StreamId> getActiveStreamIds() const;

/* toggle streams on or off */
/**
Expand Down
2 changes: 1 addition & 1 deletion core/data_provider/VrsDataProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ MotionConfigRecord VrsDataProvider::getMagnetometerConfiguration(
random access interfaces
*******************************/
/* get dimension of data */
const std::set<vrs::StreamId> VrsDataProvider::getAllStreams() const {
std::set<vrs::StreamId> VrsDataProvider::getAllStreams() const {
return interface_->getStreamIds();
}

Expand Down
2 changes: 1 addition & 1 deletion core/data_provider/VrsDataProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class VrsDataProvider {
* @brief Get all available streams from the vrs file.
* @return A set of streamIds.
*/
const std::set<vrs::StreamId> getAllStreams() const;
std::set<vrs::StreamId> getAllStreams() const;

/**
* @brief Get the tags map for all the underlying files. Does not include any stream tags.
Expand Down
10 changes: 4 additions & 6 deletions projects/AriaDigitalTwinDatasetTools/data_provider/AriaDigitalTwinDataProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,18 +315,16 @@ class AriaDigitalTwinDataProvider {

// ---- Getter of all stored data provider pointers within ADTDataProvider----
// Also provide API to the core data provider itself.
const std::shared_ptr<const tools::data_provider::VrsDataProvider> rawDataProviderPtr() const {
std::shared_ptr<const tools::data_provider::VrsDataProvider> rawDataProviderPtr() const {
return dataProvider_;
}
const std::shared_ptr<const tools::data_provider::VrsDataProvider> segmentationDataProviderPtr()
const {
std::shared_ptr<const tools::data_provider::VrsDataProvider> segmentationDataProviderPtr() const {
return segmentationProvider_;
}
const std::shared_ptr<const tools::data_provider::VrsDataProvider> depthDataProviderPtr() const {
std::shared_ptr<const tools::data_provider::VrsDataProvider> depthDataProviderPtr() const {
return depthImageProvider_;
}
const std::shared_ptr<const tools::data_provider::VrsDataProvider> syntheticDataProviderPtr()
const {
std::shared_ptr<const tools::data_provider::VrsDataProvider> syntheticDataProviderPtr() const {
return syntheticVrsProvider_;
}
std::shared_ptr<tools::mps::MpsDataProvider> mpsDataProviderPtr() {
Expand Down
Loading