Skip to content

{Build} ModernizeAvoidCArrays -- use stringviews #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gen1_legacy
Choose a base branch
from
Open

{Build} ModernizeAvoidCArrays -- use stringviews #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/calibration/camera_projections/Linear.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#pragma once

#include <cmath>
#include <string_view>

#include <calibration/camera_projections/Common.h>

Expand All @@ -32,8 +33,8 @@ class LinearProjection {
EIGEN_MAKE_ALIGNED_OPERATOR_NEW

static constexpr int kNumParams = 4;
static constexpr char kName[] = "Linear";
static constexpr char kDescription[] = "fx, fy, cx, cy";
static constexpr std::string_view kName = "Linear";
static constexpr std::string_view kDescription = "fx, fy, cx, cy";
static constexpr int kNumDistortionParams = 0;
static constexpr int kFocalXIdx = 0;
static constexpr int kFocalYIdx = 1;
Expand Down