save/load camera config to avoid read-adapting #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeaOtocinclus has imported this pull request. If you are a Meta employee, you can view this in D85343896. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading from VRS, the factory calibration is adapted to the current resolution ASSUMING that those values are for a default resolution (2880 x 2880 for RGB camera).
Therefore the process of saving and reloading from JSON is currently broken, as the scaling would be applied TWICE.
The current diff makes sure the config data are saved and used if available. if not present, the default is assumed (like when loading from VRS) and loaded as usual.
This is required to make VI-BA work.