chore(ci): use vcpkg package manager to handle dependencies #2638
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: irozzo-1A The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please double check driver/API_VERSION file. See versioning. /hold |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Wow! This would be great! I'm setting the milestone to be 0.22.0, but we can delay this if we don't feel comfortable with it! 😄 /milestone 0.22.0 |
|
Haven't gone through the PR yet, but preemptively asking just in case. We build the libraries in hermetic environments where we pre-install the dependencies we need and won't be able to have vcpkg reach out to download the dependencies itself. Am I correct thinking this new approach will also work for this use case? As long as the packages are installed with the required cmake files to find the packages, of course. Great PR BTW! Huge fan of package managers in general! |
| - name: Install deps ⛓️ | ||
| run: | | ||
| apk add g++ gcc cmake make git bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils clang llvm | ||
| apk add build-base cmake ninja zip unzip curl git curl tar g++ gcc make bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils clang llvm |
There was a problem hiding this comment.
| apk add build-base cmake ninja zip unzip curl git curl tar g++ gcc make bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils clang llvm | |
| apk add build-base cmake ninja zip unzip curl git tar g++ gcc make bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils clang llvm |
| apt update && apt install -y --no-install-recommends curl ca-certificates build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libtbb-dev libjq-dev libjsoncpp-dev protobuf-compiler libgtest-dev libprotobuf-dev linux-headers-${{ matrix.arch }} | ||
| apt update && apt install -y --no-install-recommends curl zip unzip tar ca-certificates build-essential git clang llvm pkg-config autoconf automake libtool libelf-dev wget libtbb-dev libjq-dev libjsoncpp-dev protobuf-compiler libgtest-dev libprotobuf-dev linux-headers-${{ matrix.arch }} | ||
Yep @Molter73 , you're correct this approach is supposed to work with pre-installed dependencies too. |
Thanks @terror96 for the early review! I have still some work to do here before it gets ready and it's a low priority task for me at the moment, but I'll let you know when it's in good shape 😉 |
No worries. I'll give it a better look later... |
|
:( Sorry, still having problems in selecting the right button... |
|
/milestone 0.23.0 |
What type of PR is this?
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: