-
Notifications
You must be signed in to change notification settings - Fork 39
Apply Dynamic cfg to p2 & p3 cases #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snadrus
wants to merge
73
commits into
main
Choose a base branch
from
dyn-cfg-p23
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will add a test for the eth_client by moving money between wallets and back after a failover (how many lotus nodes, stop). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds atop PR #710 (which implemented P1 items) to implement P2 & P3 items of the following punchlist.
Logic fixes: forgot 'base' changes! Atomic where better.
New component: working with Dynamic[struct{...}] required a new approach.
Misc_Included_Commits
Better testing separation by guaranteeing different databases used.
SQL:
PunchList
The remaining items are P4-5 and "No need"
Subsystems
Fees - all P2, easy, done
Addresses - all P1, hard, done
Proving - all, P4, easy
Http - no need
Market
-- MK12 - all here, P3, easy-ish, done
-- MK2, P3, done
Ingest - P1, done
Seal - No need
APIs->Chain - P2, medium-hard, done
Alerting - P3, easy, done
Batching - P2, easy, done