Skip to content

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Oct 17, 2025

This builds atop PR #710 (which implemented P1 items) to implement P2 & P3 items of the following punchlist.
Logic fixes: forgot 'base' changes! Atomic where better.
New component: working with Dynamic[struct{...}] required a new approach.

Misc_Included_Commits
Better testing separation by guaranteeing different databases used.
SQL:

  • NEW: an AFTER trigger switched to BEFORE + modifying NEW so there's no window of time for error.
  • MOD: modified old code to help reapply work better. Should have no effect on fully-upgraded setups.

PunchList
The remaining items are P4-5 and "No need"

Subsystems

  • XXMax P4, medium difficulty

Fees - all P2, easy, done
Addresses - all P1, hard, done
Proving - all, P4, easy
Http - no need
Market

  • StorageMarketConfig
    -- MK12 - all here, P3, easy-ish, done
    -- MK2, P3, done
  • IPNI - P4
  • Indexing - P5, easy
  • PieceLocator - P2, easy, done

Ingest - P1, done
Seal - No need
APIs->Chain - P2, medium-hard, done
Alerting - P3, easy, done
Batching - P2, easy, done

@snadrus snadrus marked this pull request as ready for review October 23, 2025 20:53
@snadrus snadrus requested a review from a team as a code owner October 23, 2025 20:53
@snadrus snadrus marked this pull request as draft October 23, 2025 22:04
@snadrus snadrus requested a review from magik6k October 23, 2025 23:40
@snadrus snadrus marked this pull request as ready for review October 30, 2025 14:13
@snadrus snadrus marked this pull request as draft November 6, 2025 23:56
@snadrus snadrus marked this pull request as ready for review November 7, 2025 22:52
@snadrus snadrus requested a review from LexLuthr November 7, 2025 22:59
@snadrus
Copy link
Contributor Author

snadrus commented Nov 10, 2025

I will add a test for the eth_client by moving money between wallets and back after a failover (how many lotus nodes, stop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants